Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frozenset usage, not compatible with Python2.7 #171

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Fix frozenset usage, not compatible with Python2.7 #171

merged 1 commit into from
Mar 1, 2021

Conversation

gabrielf-eb
Copy link
Contributor

@gabrielf-eb gabrielf-eb commented Mar 1, 2021 •
edited
Loading

linter in Python 2.7 is failing because how it uses frozenset

  File "/home/circleci/project/venv/lib/python2.7/site-packages/identify/identify.py", line 31
    ALL_TAGS = {*TYPE_TAGS, *MODE_TAGS, *ENCODING_TAGS}
                ^
SyntaxError: invalid syntax

gabrielf-eb referenced this pull request Mar 1, 2021
@CAM-Gerlach @asottile
Add new global constants for different tag types
bf64fcd
@gabrielf-eb gabrielf-eb mentioned this pull request Mar 1, 2021
Closed
nataliac-eb
nataliac-eb approved these changes Mar 1, 2021
View reviewed changes
Copy link

@nataliac-eb nataliac-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asottile
asottile approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 0dd163a into pre-commit:master Mar 1, 2021
asottile added a commit that referenced this pull request Mar 1, 2021
@asottile
Revert "Merge pull request #171 from gabrielf-eb/patch-1"
4fa0ead 
This reverts commit 0dd163a, reversing
changes made to f27d6eb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

@nataliac-eb nataliac-eb nataliac-eb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielf-eb @asottile @nataliac-eb