Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify config.ru rackup file as ruby #379

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Mar 21, 2023

No description provided.

@asottile
Copy link
Member

can you provide a reference? I'm having a bit of a difficult time finding what uses this

@mmlb
Copy link
Contributor Author

mmlb commented Mar 22, 2023

Hey @asottile here you go https://github.com/rack/rack#usage. I'm not super into the ruby web community but do work on a rack/rails app (I guess...?) a little bit for work. I'm not sure if it makes sense to limit to config.ru (GH search shows a few files that look like ruby that aren't explicitly named config.ru), GH's linguist just goes off of the extension .ru: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L5968

Would it be better to to just go with the extension?

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 21bbf2d into pre-commit:main Mar 24, 2023
@mmlb mmlb deleted the indentify-rackup-config branch March 24, 2023 21:47
@mmlb
Copy link
Contributor Author

mmlb commented Mar 24, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants