-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document/set up support tooling for editor integrations #185
Comments
hi @asottile . @RonnyPfannschmidt asked me for using same version of black (in editor and command line) via pre-commit.
|
@jgirardet would it be sufficient to limit the pre-commit hook run to only/exactly the black hook, if the env is cached already that might be really quick |
I'm not sure what you mean here, that's essentially what |
the idea was to run black via precommit but without the whole bunch of things that pre commit do, to save some time. |
there isn't really anything that pre-commit does beyond collect the args and subprocess, last time I profiled it it essentially boiled down to:
And factoring out pkg_resources isn't easy. |
some rough numbers:
|
thank you for your answers @asottile |
Note that |
@asottile great job, thanks 👍 |
feel free to send PRs for editor integrations -- going to close this since there isn't really anything actionable at the moment |
follow-up to jgirardet/sublack#31
deferred from pre-commit/pre-commit#838
as i conversed with sublack author, it became apparent that its pretty hard/tricky to integrate pre-commit/black for example with editor integrations (in order to fix exact project set-ups)
i wonder if the issue can be elevated/helped in some way
The text was updated successfully, but these errors were encountered: