Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document/set up support tooling for editor integrations #838

Closed
RonnyPfannschmidt opened this issue Oct 4, 2018 · 5 comments
Closed

document/set up support tooling for editor integrations #838

RonnyPfannschmidt opened this issue Oct 4, 2018 · 5 comments

Comments

@RonnyPfannschmidt
Copy link

follow-up to jgirardet/sublack#31

as i conversed with sublack author, it became apparent that its pretty hard/tricky to integrate pre-commit/black for example with editor integrations (in order to fix exact project set-ups)

i wonder if the issue can be elevated/helped in some way

@asottile
Copy link
Member

asottile commented Oct 4, 2018

I've used pre-commit run --files $filename myself w/ editors which works pretty well. This does require that the file is written out beforehand 🤷‍♂️

@asottile
Copy link
Member

asottile commented Oct 4, 2018

@RonnyPfannschmidt can you reopen this on the docs repo? https://github.com/pre-commit/pre-commit.github.io

@RonnyPfannschmidt
Copy link
Author

@asottile i suppose supporting input from streams is not directly sensible=?

@asottile
Copy link
Member

asottile commented Oct 4, 2018

pre-commit works entirely on filenames today -- it could probably be made to support /dev/stdin / - (and skip filtering it against the checked in files)? I'd have to see a pretty good reason for it though :) (and I'm not sure avoiding a disk flush is really going to save that much time)

@RonnyPfannschmidt
Copy link
Author

@asottile true in case of doubt tmpfs ftw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants