-
Notifications
You must be signed in to change notification settings - Fork 23
use exact black version pre-commit uses #31
Comments
I've never used precommit so I do not really understand. |
is an example of the usage - we use it to ensure all commits are up to standard, now if the black the editor uses and the black the commit checking uses differ in version, there is the possibility of different outcomes (as black enhances) |
if I get you, you'd like to run |
@jgirardet i believe the black options should always be taken from black or pre-commit if feasible, its bit of - idealls sublack has no own options and defers everything to the project/its tooling, else developer preference differences will cause havoc |
Hi @RonnyPfannschmidt
So i'm not sure about running sublack via precommit by defaut if black's hook is present. The other matter comes with unsaved file : since I use
Last thing, Please tell if I'm wrong or if you think to another/better implementation. |
@jgirardet that's indeed a unfortunate setup - i will open a accompanying issue for pre-commit as its definitively a useful item |
Hi @RonnyPfannschmidt , |
It's on master. you have to use the option "black_use_precommit" |
in v 2.1.0 |
people combining pre-commit and black tend to pin the black version to control transition and formatting,
as black enhances it sometimes introduces better formatting that will conflict with a projects pinned setup
in order to avoid this dissonance it would be really useful to either use black from pre-commit if available or to take the same version
The text was updated successfully, but these errors were encountered: