rename "method" in event handler to "sub"

This is going to be the future of "How do I get a subref as a service?" In this case, the subref will call the object method. This change disambiguates the "method" key. It is now back to, in this instance, being the name of the class constructor. This should allow for anonymous event handlers. Fixes #46
preaction · Mar 8, 2015 · 0fd065d · 0fd065d
1 parent 40d3003
commit 0fd065d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/lib/Beam/Wire.pm b/lib/Beam/Wire.pm
@@ -782,11 +782,9 @@ sub create_service {
 
         for my $listener ( @listeners ) {
             my ( $event, $conf ) = @$listener;
-            # XXX: Make $args prepend arguments to the listener
-            # XXX: Make $args also resolve refs
-            my $method = delete $conf->{ $meta{method} };
+            my $sub_name = delete $conf->{ $meta{sub} };
             my ( $listen_svc ) = $self->find_refs( $conf );
-            $service->on( $event => sub { $listen_svc->$method( @_ ) } );
+            $service->on( $event => sub { $listen_svc->$sub_name( @_ ) } );
         }
     }
 
@@ -868,6 +866,7 @@ sub get_meta_names {
         args    => "${prefix}args",
         class   => "${prefix}class",
         extends => "${prefix}extends",
+        sub     => "${prefix}sub",
     );
     return wantarray ? %meta : \%meta;
 }

diff --git a/t/14_on_event.t b/t/14_on_event.t
@@ -13,7 +13,7 @@ subtest 'single event listener' => sub {
                 on => {
                     greet => {
                         '$ref' => 'listener',
-                        '$method' => 'on_greet',
+                        '$sub' => 'on_greet',
                     },
                 },
             },
@@ -42,11 +42,11 @@ subtest 'multiple event listeners' => sub {
                         greet => [
                             {
                                 '$ref' => 'listener',
-                                '$method' => 'on_greet',
+                                '$sub' => 'on_greet',
                             },
                             {
                                 '$ref' => 'other_listener',
-                                '$method' => 'on_greet',
+                                '$sub' => 'on_greet',
                             },
                         ],
                     },
@@ -78,13 +78,13 @@ subtest 'multiple event listeners' => sub {
                         {
                             greet => {
                                 '$ref' => 'listener',
-                                '$method' => 'on_greet',
+                                '$sub' => 'on_greet',
                             },
                         },
                         {
                             greet => {
                                 '$ref' => 'other_listener',
-                                '$method' => 'on_greet',
+                                '$sub' => 'on_greet',
                             },
                         },
                     ],
@@ -120,7 +120,7 @@ subtest 'anonymous listeners' => sub {
                     on => {
                         greet => {
                             '$class' => 'My::Listener',
-                            '$method' => 'on_greet',
+                            '$sub' => 'on_greet',
                         },
                     },
                 },
@@ -143,7 +143,7 @@ subtest 'anonymous listeners' => sub {
                     on => {
                         greet => {
                             '$extends' => 'listener',
-                            '$method' => 'on_greet',
+                            '$sub' => 'on_greet',
                         },
                     },
                 },