API failing to render json

[kiwiroy]

With recent changes to the way Mojolicious routes for requests with format parameters the editor no longer retrieves data from the api but instead errors with a TypeError: items is undefined at /yancy/app.js:693.

As mentioned on IRC:

Yancy/lib/Mojolicious/Plugin/Yancy/resources/public/yancy/app.js

Line 682 in 4211183

$.get( this.currentOperations["list"].url, query ).done(

could be changed to.

$.get( this.currentOperations["list"].url, query, null, 'json' ).done( 

Without this, the request headers are Accept: */* and json is never selected as a format in Yancy::Controller#list ($c->respond_to).

However, Yancy goes to lengths to set the format to json for api routes in

Yancy/lib/Yancy/Plugin/Editor.pm

Lines 420 to 457 in 4211183

	if ( $method eq 'get' ) {
	# heuristic: is per-item if have a param in path
	if ( $id_field ) {
	# per-item - GET = "read"
	return {
	action => 'get',
	format => 'json',
	};
	}
	else {
	# per-schema - GET = "list"
	return {
	action => 'list',
	format => 'json',
	};
	}
	} elsif ( $method eq 'post' ) {
	return {
	action => 'set',
	format => 'json',
	};
	} elsif ( $method eq 'put' ) {
	die "'$method' $path needs id_field" if !$id_field;
	return {
	action => 'set',
	format => 'json',
	};
	} elsif ( $method eq 'delete' ) {
	die "'$method' $path needs id_field" if !$id_field;
	return {
	action => 'delete',
	format => 'json',
	};
	}
	else {
	die "Unknown method '$method'";
	}
	}

Mojolicious::Plugin::OpenAPI reverses this by undefing format when configuring the route https://github.com/jhthorsen/mojolicious-plugin-openapi/blob/master/lib/Mojolicious/Plugin/OpenAPI.pm#L232-L233

M::P::OpenAPI could be patched, but I'll open a PR for a local fix.

[preaction]

Fixed by merging #133. Thanks!