-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install dependencies in PnP projects #43
Open
arendjr
wants to merge
1
commit into
preactjs:master
Choose a base branch
from
arendjr:Dont-install-dependencies-in-PnP-projects
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, it should run an install either way as the
.yarn/unplugged
folder is usually not commited.You can detect Yarn 2 by checking the
yarn.lock
file for__metadata:
and runningyarn --immutable
to installThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, interesting. I guess we can indeed include #41 into this PR to offer generic Yarn 2 support. But the Zero Install documentation suggests people may also check-in the unplugged directories (indeed, we do for our project). Now I could simply detect whether the unplugged directory exists, and if it does we still don't need to install. But Git doesn't maintain empty directories... so if it doesn't exist, does that mean we should install (at least it's the safe thing to do) or doesn't it exist because no packages had postinstall scripts? Would it be too convoluted to check
.gitignore
, and assume we need to do the install if we seeunplugged
is listed there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The easiest and safest way forward is to always trigger the install, if you're using Zero-Installs and commit everything it's basically a noop.
The existance, or lack thereof, of a
.yarnrc.yml
file isn't enough, the correct way to check is to grepyarn.lock
for__metadata:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a reference to somewhere the
__metadata
is documented? I do believe you, but it feels like relying on an incidental side-effect of the lock file to detect the version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did find this in the docs: https://yarnpkg.com/getting-started/migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't, but as one of the maintainers of Yarn I can suggest using this to detect it.
That was true at the time it was written, but once we get https://github.com/nodejs/corepack released with node that file is not guaranteed to exist (it isn't either way but oh well).