Allow an async component to return null rendering (#1438)

Co-authored-by: Jason Miller <developit@users.noreply.github.com>
preactjs · Oct 30, 2020 · 2c53b0a · 2c53b0a
1 parent 6670ba0
commit 2c53b0a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/.changeset/famous-dolls-leave.md b/.changeset/famous-dolls-leave.md
@@ -0,0 +1,5 @@
+---
+"preact-cli": patch
+---
+
+fix: allow an async component to return null rendering
diff --git a/packages/async-loader/async.js b/packages/async-loader/async.js
@@ -49,12 +49,11 @@ export default function async(load) {
 			const me =
 				(prev && prev.nextSibling) || (this.__P || this._parentDom).firstChild;
 
-			return (
-				me &&
-				h(me.localName, {
-					dangerouslySetInnerHTML: PENDING,
-				})
-			);
+			if (!me) return;
+			if (me.nodeType === 3) return me.data;
+			return h(me.localName, {
+				dangerouslySetInnerHTML: PENDING,
+			});
 		};
 	}