preact build doesn't exit with proper code on error

[thangngoc89]

preact build always exit with code = 0 where there are errors or not. And this is pretty annoying because you can't catch this on CI.

P/s: After a quick digging, a try ...catch block is missing here https://github.com/developit/preact-cli/blob/35fd84a86fe6b6c8abd60aeb721494771930c4ff/src/commands/build.js#L41 .
I think it's the root of this evil

[developit]

ah actually it looks like asyncCommand isn't accounting for synchronous errors in the async functions (promises): https://github.com/developit/preact-cli/blob/master/src/lib/async-command.js#L16-L17

[thangngoc89]

@developit Is there anything I can help to push this forward? This is killing my CI workflow.

[oren]

I would love to hear more about your CI workflow (:

[thangngoc89]

@oren I think it's called continous development && deployment process. I use Gitlab CI to automatically test each commit and then automatically deploy the site to my server. If there is an error (test process exited with non-zero code) , the CI will emit an error and cancel the deployment.

[oren]

Got it. Thanks

…

On Jun 8, 2017 7:20 AM, "Khoa Nguyen" ***@***.***> wrote: @oren <https://github.com/oren> I think it's called continous development && deployment process. I use Gitlab CI to automatically test each commit and then automatically deploy the site to my server. If there is an error (test process exited with non-zero code) , the CI will emit an error and cancel the deployment. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZdSUd3OJQgtRqIIaq102QomUU67mDks5sCAM5gaJpZM4NoD04> .