-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: build test suite #1670
Conversation
🦋 Changeset detectedLatest commit: 96df7de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f8c49cc
to
b62c869
Compare
try { | ||
await symlink( | ||
join(from, 'node_modules', name), | ||
join(to, 'node_modules', name) | ||
); | ||
} catch {} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case this looks odd: when running multiple builds in the same test fixture (such as testing option: true
& option: false
together), symlinking would be triggered twice, as it's called on build. fs.symlink()
throws if the symlink already exists, so we should catch & ignore those cases.
49b2638
to
0f97190
Compare
97b5bdd
to
324e0c2
Compare
Co-authored-by: Leah <github.leah@hrmny.sh>
324e0c2
to
96df7de
Compare
What kind of change does this PR introduce?
Minor bugfixes, mostly added tests
Did you add tests for your changes?
yes
Summary
Wasn't feeling comfortable with the Webpack v5 branch, so I took to writing tests.
This fixes two very minor issues:
--json
flag usedprocess.cwd()
, rather than CLI'scwd
/
The build suite still skips the
--cwd
,--brotli
, and--vebose
flags.--cwd
powers our entire test suite, so it's a bit redundant to test--brotli
doesn't seem to work on a default app, not quite sure what it's supposed to do either. Static compression of assets? Might be up for removal.--verbose
is not particularly useful, we don't hide many logs behind that. Just debug stack traces really. Not worth testing at the moment.I'm sure I'm still missing plenty of behaviors but this is a start, anyways.
Does this PR introduce a breaking change?
No