Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Node v6 as minimum support #168

Merged
merged 3 commits into from
Jul 1, 2017
Merged

Declare Node v6 as minimum support #168

merged 3 commits into from
Jul 1, 2017

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Jun 30, 2017

The engines key will only show a warning to NPM installers. It's not perfect, but at least it's something.

Although we were compiling to Node 4 and our code worked in a Node 4 environment (I just tried, dat npm install doe...💤 ), we have several dependencies that require 5+ and 6+ and our dependency resolution was fighting against NPM's dependency tree (typical).

So with this, we're now compiling to Node 6 & actively declaring a 6+ minimum.

I removed Node 7 from Travis because we're already testing v8 and v7 literally brings nothing unique to the table. This will make tests completely a bit sooner.

References #165

@lukeed
Copy link
Member Author

lukeed commented Jun 30, 2017

Oh, and normally this would be a breaking change for a library. But it isn't for us because we've already been informally requiring Node 6. This is just formally writing it down. 📝

@lukeed lukeed requested a review from rkostrzewski June 30, 2017 23:26
@rkostrzewski rkostrzewski merged commit 60c3e39 into master Jul 1, 2017
@thangngoc89 thangngoc89 deleted the engine branch July 1, 2017 15:42
@rkostrzewski rkostrzewski added this to the 1.4.0 milestone Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants