-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Restricts preact.config.js
's env
types to a more idiomatic subset
#1735
Conversation
🦋 Changeset detectedLatest commit: 3efc14d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is |
Yes, Regret it as in think it should change to something else? |
Yeah, SSR is a bit of a misnomer there. Unless folks are still abusing it for SSR? haha |
Some still are or at least want to, but I've been dissuading. I'm somewhat partial to That might just be me doing mental gymnastics to justify what I'm familiar with though. |
What kind of change does this PR introduce?
refactor of
preact.config.js
typesDid you add tests for your changes?
N/A
Summary
Goes along with #1734
env
inpreact.config.js
is quite overloaded and has numerous semi-duplicated values:production
andisProd
,ssr
andisServer
, etc. I'd like to cut this down to justisProd
,isDev
, andisServer
in v4, but for now, a good start would be to restrict the types & update the wiki.At best, the types/values beyond these three (and their duplicates) are just convenience (not having to get the path for
src
yourself), and at worst, confuse new users.Does this PR introduce a breaking change?
No