Feature/145

[MobiusHorizons]

Fixes #145

[developit]

I think this makes sense!

[developit]

Only thing we'll need is to have it also remove extra elements that may have been contained in parent on initial render. Right now it leaves the <p> in the example below:

<div id="app">
  <section id="root">to be rendered by preact-compat</section>
  <p>should be removed since it's not in the vtree</p>
</div>

render(<section id="root">rendered</section>, $('#app'));
console.log( $('#app').children.length );  // 2, should be 1

(or at least this is my understanding of what React seems to do)

[MobiusHorizons]

@developit, I have added a test that I believe covers this case. Please see the updated code.

[developit]

Might be an issue with multiple node removal here. .children is a Live NodeList and so calling removeChild() on the second child actually shifts the list :o

I don't mind tweaking it after merge if you're getting the desired result though, I really appreciate your work on this!

[MobiusHorizons]

Good point, I will fix it. I also realized that textnodes in the parent wouldn't be taken care of, since they don't show up as children.

[developit]

Indeed! Switching to childNodes should fix that.

[MobiusHorizons]

Alright, I think this covers my use cases. tweak as necessary.

[developit]

Looks great, I'll merge as soon as I have a sec!

[MobiusHorizons]

cool, glad to hear it.

[chiragmongia]

I would love to see this getting merged! 😃

[developit]

Released as 3.0.0! 🎉