This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Add support for defaultValue to preact-compat #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
reviewed
Jan 12, 2017
| @@ -15,6 +15,7 @@ | |||
| "test": "npm-run-all lint build test:karma", | |||
| "lint": "eslint {src,test}", | |||
| "test:karma": "karma start --single-run", | |||
| "test:watch": "karma start --watch", | |||
There was a problem hiding this comment.
Just a note - I believe karma start watches by default.
There was a problem hiding this comment.
I bet you're right. I'll adjust as needed.
developit
reviewed
Jan 12, 2017
| @@ -82,14 +82,24 @@ options.vnode = vnode => { | |||
| } | |||
| } | |||
| else if (attrs) { | |||
| if (typeof vnode.nodeName==='string' && vnode.attributes && vnode.attributes.defaultValue) { | |||
| addDefaultValue(vnode); | |||
There was a problem hiding this comment.
@gholtslander-va I know we started out with this as a separate function, but I'm thinking since it ended up being pretty small (and not creating a closure) we should inline it for bundle size.
if (typeof vnode.nodeName==='string' && attrs && attrs.defaultValue) {
if (!attrs.value && attrs.value!==0) {
attrs.value = attrs.defaultValue;
}
delete attrs.defaultValue;
}Seem reasonable?
developit
suggested changes
Jan 12, 2017
developit
approved these changes
Jan 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
This adds support for this functionality which I missed from the first time I tried out preact-compat. Somehow I forgot that it was missing until I went to release my app to some beta users today and realized it was kinda broken as it is haha.
I worked on this with @developit so hopefully it doesn't need much massaging to merge 👍