Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Should export instance when call renderSubtreeIntoContainer. #296

Merged
merged 1 commit into from Feb 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
Expand Up @@ -168,7 +168,7 @@ function renderSubtreeIntoContainer(parentComponent, vnode, container, callback)
let wrap = h(ContextProvider, { context: parentComponent.context }, vnode);
let c = render(wrap, container);
if (callback) callback(c);
return c;
return c._component || c.base;
}


Expand Down
31 changes: 30 additions & 1 deletion test/index.js
@@ -1,4 +1,4 @@
import React, { render, createClass, createElement, cloneElement, Component, PropTypes } from '../src';
import React, { render, createClass, createElement, cloneElement, Component, PropTypes, unstable_renderSubtreeIntoContainer } from '../src';

describe('preact-compat', () => {
describe('render()', () => {
Expand Down Expand Up @@ -238,4 +238,33 @@ describe('preact-compat', () => {
expect(cloneElement(element)).to.eql(element);
});
});

describe('unstable_renderSubtreeIntoContainer', () => {
it('should export instance', () => {
class Inner extends Component {
render() {
return null;
}
getNode() {
return 'inner';
}
}

class App extends Component {
render() {
return null;
}
componentDidMount() {
this.renderInner();
}
renderInner() {
const wrapper = document.createElement('div');
this.inner = unstable_renderSubtreeIntoContainer(this, <Inner/>, wrapper);
}
}
const root = document.createElement('div');
const app = render(<App/>, root);
expect(typeof app.inner.getNode === 'function').to.equal(true);
});
});
});