This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Use reactjs offical proptypes lib. #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh, it's 1kb instead of 1.6kb too! |
|
Hmm - looks like its a noop in prod but fairly large in dev. I'm getting an error though when I try to emulate this on jsfiddle: it seems like the new prop-types module doesn't allow manual validation? They require that you have access to an internal object for some reason: |
|
@developit have you tried in combination with #350? I've been running this combo locally with success. |
|
Yes @developit. Ill go ahead and close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.