Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for default context value #130

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Fix support for default context value #130

merged 1 commit into from
Dec 19, 2019

Conversation

loklaan
Copy link
Contributor

@loklaan loklaan commented Dec 18, 2019

Issue here was that the mangled _defaultValue prop wasn't being used. 😱

Pretty edge case for most libraries I suppose, which is why it might not have been caught yet

Checklist

  • Added test

@loklaan
Fix support for default context value
7267769 
Issue here was that the mangled "_defaultValue" prop wasn't being used.
marvinhagemeister
marvinhagemeister approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that's a good catch 👍 Thank you so much for your PR 🎉 💯

@marvinhagemeister marvinhagemeister merged commit 483768d into preactjs:master Dec 19, 2019
@marvinhagemeister
Copy link
Member

Published as 5.1.3 🎉

@loklaan
Copy link
Contributor Author

loklaan commented Dec 19, 2019

Yaaas - quick publish! ty

@loklaan loklaan mentioned this pull request Dec 19, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loklaan @marvinhagemeister