fix cjs export #285
Merged
fix cjs export #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de4154b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
requested review from
marvinhagemeister,
andrewiggins and
developit
andrewiggins
reviewed
Mar 6, 2023
| @@ -28,7 +28,7 @@ | |||
| "bench:v8": "BABEL_ENV=test microbundle benchmarks/index.js -f modern --alias benchmarkjs-pretty=benchmarks/lib/benchmark-lite.js --external none --target node --no-compress --no-sourcemap --raw -o benchmarks/.v8.mjs && v8 --module benchmarks/.v8.mjs", | |||
| "build": "npm run -s transpile && npm run -s transpile:jsx && npm run -s copy-typescript-definition", | |||
| "postbuild": "node ./config/node-13-exports.js && node ./config/node-commonjs.js", | |||
| "transpile": "microbundle src/index.js -f es,umd --target web --external preact", | |||
| "transpile": "microbundle src/index.js -f es,cjs --target web --external preact", | |||
| "transpile:jsx": "microbundle src/jsx.js -o dist/jsx.js --target web --external preact && microbundle dist/jsx.js -o dist/jsx.js -f cjs --external preact", | |||
There was a problem hiding this comment.
Does this mean we are no longer producing a build that can load in a browser? What's the bug here?
There was a problem hiding this comment.
It's using umd globals and it seems like with the named export removed that gives some issues. Can look deeper into it though
|
@andrewiggins added back umd and streamlined export maps with the preact ones |
andrewiggins
approved these changes
Mar 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.