Avoid in-place mutation of the attributes of Router's children #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All credit for this change goes to @developit (who sent it over Slack)
rmacklin
commented
Apr 7, 2017
| @@ -0,0 +1,12 @@ | |||
| import { cloneElement } from 'preact'; | |||
There was a problem hiding this comment.
I put this file in a new test_helpers directory, because it's not a test itself, but it's imported by some of the tests. If you'd prefer it live within the test directory, or a subdirectory inside test (e.g. test/helpers), I'd be happy to move it there. We'll just need to modify files: ['test/**/*.js'] in the karma config to exclude this if we move it inside test.
There was a problem hiding this comment.
I'm good with how you laid it out :)
rmacklin
changed the title
developit
approved these changes
Apr 9, 2017
| @@ -0,0 +1,12 @@ | |||
| import { cloneElement } from 'preact'; | |||
There was a problem hiding this comment.
I'm good with how you laid it out :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163