Fixes Typecheck bug in preactjs/preact#3934 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reserving functionality.
|
@marvinhagemeister @rschristian Let me know what you think and if any changes are required. |
rschristian
reviewed
Jul 21, 2023
rschristian
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
CI failure is due to us having an older version of Preact (without SignalLike) as a devDep, nothing you necessarily need to worry about though I don't love the idea of increasing the minimum supported Preact version (if the user wants TypeScript support, anyways).
|
Thanks for the quick response! Let me know if I can help more with this or anything else. |
rschristian
reviewed
Jul 21, 2023
| "chai": "^3.5.0", | ||
| "copyfiles": "^1.0.0", | ||
| "chai": "^4.3.7", |
There was a problem hiding this comment.
See #453 for justification, but need to update some of these here w/ the type fix to satisfy CI.
|
We really appreciate the fix! ❤️ I'll try to cut a release in a bit, after my dinner. |
This was referenced Jul 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SignalLike as an option for default that fixes /preact/issues/3934 while preserving current functionality. This is a simple fix but it seems like it would do what's needed.