fix: fix #432 to support signals #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
reviewed
May 1, 2023
There was a problem hiding this comment.
Sorry for the long-time-no-look, but this change causes a few immediately noticeable issues too:
HTMLAttributes<HTMLElement>seemingly doesn't accept children, so even something like the following is a no-go:
<header>
<p>Hello World!</p>
</header>refisn't a valid HTML attribute, so that causes issues too.
I don't know what the correct solution is myself, however. We're looking at this over at preactjs/preact#3934
| @@ -17,9 +17,8 @@ export interface CustomHistory { | |||
| replace(path: string): void; | |||
| } | |||
|
|
|||
| export interface RoutableProps { | |||
| export interface RoutableProps extends Pick<HTMLAttributes<HTMLElement>, 'default'> { | |||
There was a problem hiding this comment.
Suggested change
| export interface RoutableProps extends Pick<HTMLAttributes<HTMLElement>, 'default'> { | |
| export interface RoutableProps extends Pick<preact.JSX.HTMLAttributes<HTMLElement>, 'default'> { |
|
Superseded by #452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript compiler complains on the type conflict after signal support in Preact's type.
See #432 for more details.
Solution
RoutablePropsby picking native HTMLdefaultattribute