Further simplify placeChild with newly unnecessary conditions

preactjs · Oct 26, 2023 · e3378e0 · e3378e0
1 parent 74e603e
commit e3378e0
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -310,13 +310,8 @@ export function toChildArray(children, out) {
 }
 
 function placeChild(parentDom, newDom, oldDom) {
-	// TODO: How do we enter here when oldDom isn't in parentDom? We should fix
-	// that such that it never happens. Changing `oldDom.parentNode !== parentDom`
-	// to `!oldDom.isConnected` also passes our test suite.
-	if (oldDom == null || oldDom.parentNode !== parentDom) {
-		parentDom.insertBefore(newDom, null);
-	} else if (newDom != oldDom) {
-		parentDom.insertBefore(newDom, oldDom);
+	if (newDom != oldDom) {
+		parentDom.insertBefore(newDom, oldDom || null);
 	}
 
 	return newDom.nextSibling;