-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InnerMost Component isn't firing 'WillMount', 'DidMount' when re-render #143
Comments
@zhenkunou Looks like this is part of the regression in |
Fix is on the way! :) |
Awesome! |
@zhenkunou I've released this under the beta tag: |
Marking this as closed since both of our tests pass. I'll make an announcement when it's rolled out of beta :) |
Note: confirmed fix verification http://codepen.io/developit/pen/reXZvd?editors=0010 |
Great work, Thanks!!! |
@developit it seem that the bug is still here:
The http://codepen.io/ryan_ou/pen/QNYegz?editors=0011 |
@zhenkunou Yikes! Sorry about that - I've got a fix coming. The original fix missed a code path for remounting nested trees of components. |
…or better compatibility with React 16.6 (#143)
in my case:
when the
<Panel/>
re-render, the<Title/>
isn't firing 'WillMount', 'DidMount' etc.codepen: http://codepen.io/ryan_ou/pen/QNYegz?editors=0011
The text was updated successfully, but these errors were encountered: