-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key property not exist on virtual dom #155
Comments
Perhaps preact should consider aligning their vdom properties with those of react. |
Definitely something to consider. Preact-compat patches VNode to match React, but internally it would make little difference. Might be something I implement as part of |
I have a confirmed fix for the |
@chemzqm I've released this under the beta tag: |
marvinhagemeister
added a commit
that referenced
this issue
Mar 15, 2022
…rops Keep state changes during getDerivedStateFromProps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using react component animate to help me add animation to element(s), but I found not like what react did, preact not have key property on the dom:
As a result, the animation library fails to find the key and throw an error.
It would be nice if we can make
key
to be a readonly property on the virtual dom by usingObject.defindeProperty
The text was updated successfully, but these errors were encountered: