Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldComponentUpdate() runs on component after forceUpdate() #158

Closed
leonid-bauxy opened this issue May 23, 2016 · 2 comments
Closed

shouldComponentUpdate() runs on component after forceUpdate() #158

leonid-bauxy opened this issue May 23, 2016 · 2 comments
Labels
compat
Milestone
5.0

Comments

@leonid-bauxy
Copy link
Contributor

It shouldn't: https://facebook.github.io/react/docs/component-api.html#forceupdate
@developit
Copy link
Member

Ah, great catch! It was added recently but I must have missed that bit.

@developit developit added this to the 5.0 milestone May 23, 2016
@developit
Copy link
Member

Released in 5.0.0-beta2.

@leonidborisenko leonidborisenko mentioned this issue Jun 11, 2016
Closed
marvinhagemeister pushed a commit that referenced this issue Mar 2, 2019
@andrewiggins
Enable passing shouldComponentUpdate test (#158)
ed73f4b
marvinhagemeister added a commit that referenced this issue Mar 15, 2022
@marvinhagemeister
Merge pull request #158 from preactjs/bugfix/aria-boolean-values
ab13881 
Stringify boolean aria-* attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@developit @leonid-bauxy