Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input loses focus #159

Closed
jrvidal opened this issue May 23, 2016 · 2 comments
Closed

Input loses focus #159

jrvidal opened this issue May 23, 2016 · 2 comments
Labels
bug compat has fix

Comments

@jrvidal
Copy link

jrvidal commented May 23, 2016

Codepen: http://codepen.io/anon/pen/ONKxeZ (write something in the input box to see the effect)

I tested a similar scenario with React and it works correctly. Apparently Preact detaches the text input during reconciliation, losing all focus info.
@developit
Copy link
Member

Thanks for the bug report! You're right, this is unintentional. I have a fix, will publish it as soon as I can verify with some large codebases.

@developit
Copy link
Member

Released in 5.0.0-beta2.

marvinhagemeister added a commit that referenced this issue Mar 2, 2019
@marvinhagemeister
Merge pull request #159 from developit/simplify-diffChildren-oldVNode
91116e3 
Simplify finding oldVNode in diffChildren (-14 B)
marvinhagemeister pushed a commit that referenced this issue Mar 2, 2019
@andrewiggins
Revert changes to diffChildren from #159 - Simplify finding oldVNode …
8487a02 
…in diffChildren (+14 B)

It turns out that in [diffchildren-index-tracing-2](https://github.com/developit/ceviche/tree/diffchildren-index-tracing-2)
(which I'd like to open a PR for), I have to bring back the index
tracking that #159 removed. So before I open a PR for
diffchildren-index-tracing-2, I'd like to revert the changes to
diffChildren from #159 so that it is easier to see the real changes that
the index tracing introduces.
marvinhagemeister pushed a commit that referenced this issue Mar 2, 2019
@andrewiggins
Merge #164: Revert changes to diffChildren from #159 - Simplify findi…
8e3165a 
…ng oldVNode in diffChildren

Revert changes to diffChildren from #159 - Simplify finding oldVNode in diffChildren (+14 B)
@snyk-bot snyk-bot mentioned this issue Feb 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compat has fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developit @jrvidal