Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eager init of _renderCallbacks to avoid checks on it #1113

Merged
merged 4 commits into from May 28, 2018
Merged

eager init of _renderCallbacks to avoid checks on it #1113

merged 4 commits into from May 28, 2018

Conversation

valotas
Copy link
Contributor

@valotas valotas commented May 20, 2018

size also improves a little bit

@coveralls
Copy link

coveralls commented May 20, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 393d488 on valotas:perf-improve into 78ce6cd on developit:master.

@developit
Copy link
Member

Nice! We should grab perf numbers for this locally, but I think this is the way to go!

@developit developit self-requested a review May 22, 2018 14:40
@marvinhagemeister
Copy link
Member

marvinhagemeister commented May 28, 2018 •
edited

Results for my Macbook Pro 15" 2016:

Test master PR
empty diff 89384/s (30 ticks) 89288/s (30 ticks)
repeat diff 11450/s (237 ticks) 11034/s (249 ticks)
large VTree 42185/s (64 ticks) 43455/s (62 ticks)
style/prop mutation 20205/s (131 ticks) 20533/s (132 ticks)
SSR Hydrate 1379/s (1941 ticks) 1356/s (1984 ticks)

Edit: Ran tests a few times, the results seem to be the same and the differences seem to be caused by inaccuracy of measurement.

Edit2: Forgot to compare bundle sizes: This PR saves 7 bytes 🎉

marvinhagemeister
marvinhagemeister approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution 🎉

@marvinhagemeister marvinhagemeister merged commit feb96b5 into preactjs:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@valotas @coveralls @developit @marvinhagemeister @reznord