Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve react devtools global hook (fixes #1330) #1333

Merged
merged 1 commit into from Mar 5, 2019
Merged

Preserve react devtools global hook (fixes #1330) #1333

merged 1 commit into from Mar 5, 2019

Conversation

developit
Copy link
Member

@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 1dbc638 on x-react-devtools-hook into ac8e1f0 on master.

marvinhagemeister
marvinhagemeister approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 There mixed tabs in spaces in there, which is why the indentation looks off. Not sure if that was caused by terser

@developit
Copy link
Member Author

Nah i used the web editor, my bad

@marvinhagemeister marvinhagemeister merged commit 75944d9 into master Mar 5, 2019
@marvinhagemeister marvinhagemeister deleted the x-react-devtools-hook branch March 5, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@developit @coveralls @marvinhagemeister