Switch to raf+setTimeout from MC #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
Mar 6, 2019
marvinhagemeister
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
LGTM, but I'd love to have @andrewiggins review it before merging :)
cristianbote
requested review from
developit,
andrewiggins and
marvinhagemeister
and removed request for
developit and
andrewiggins
marvinhagemeister
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing #1341.
Basically, go with raf + setTimeout solution. There's a possible clamping here, but let's discuss it.
cc @andrewiggins @developit @marvinhagemeister
-33B-30B