Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stale props reference when sCU returns false #1351

Merged
merged 2 commits into from Mar 7, 2019
Merged

Fix stale props reference when sCU returns false #1351

merged 2 commits into from Mar 7, 2019

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 6, 2019 •
edited

Adds +3 +2 bytes 馃帀 Fixes #1345 .

@marvinhagemeister marvinhagemeister force-pushed the stale_props_scu branch 2 times, most recently from e842045 to 2081017 Compare March 6, 2019 21:32
@mochiya98
Copy link
Contributor

thanks! isn't it necessary to update state? maybe causes a similar problem.

@marvinhagemeister
Copy link
Member Author

Good point! I'll check if the same issue applies for state

@developit
Copy link
Member

Seems like we'll want state as well, yeah.

@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 661dbfb on stale_props_scu into 18d0145 on master.

@marvinhagemeister
Copy link
Member Author

Can confirm: The state is updated but is never referentially equal https://codesandbox.io/s/j00kl29rv

@marvinhagemeister marvinhagemeister force-pushed the stale_props_scu branch 2 times, most recently from 3c0a463 to e0c7fa9 Compare March 7, 2019 17:58
@marvinhagemeister
Copy link
Member Author

marvinhagemeister commented Mar 7, 2019 •
edited

hold on I somehow messed up the history.

EDIT: fixed, I somehow had a commit from master in my PR

@developit developit self-requested a review March 7, 2019 19:13
@marvinhagemeister marvinhagemeister merged commit 4ca7320 into master Mar 7, 2019
@marvinhagemeister marvinhagemeister added this to Closed in Beta Issues via automation Mar 7, 2019
@marvinhagemeister marvinhagemeister deleted the stale_props_scu branch March 7, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Beta Issues
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marvinhagemeister @mochiya98 @developit @coveralls