Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont leak Text vnodes out of toChildArray #1357

Merged
merged 4 commits into from Mar 7, 2019
Merged

Dont leak Text vnodes out of toChildArray #1357

merged 4 commits into from Mar 7, 2019

Conversation

developit
Copy link
Member

@developit developit commented Mar 7, 2019 •
edited

before:

const vnode = <div>a</div>;
toChildArray(vnode.props.children) // [{ text: 'a' }]

after:

const vnode = <div>a</div>;
toChildArray(vnode.props.children) // ['a']

+7b

@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 5887943 on dont-leak-text-vnodes into c66ec75 on master.

andrewiggins
andrewiggins approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 18d0145 into master Mar 7, 2019
@marvinhagemeister marvinhagemeister deleted the dont-leak-text-vnodes branch March 7, 2019 18:21
@marvinhagemeister marvinhagemeister added this to Closed in Beta Issues Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Beta Issues
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@developit @coveralls @andrewiggins @marvinhagemeister