Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all forwardRef tests pass #1358

Merged
merged 3 commits into from Mar 14, 2019
Merged

Make all forwardRef tests pass #1358

merged 3 commits into from Mar 14, 2019

Conversation

marvinhagemeister
Copy link
Member

Ported this PR over from the ceviche repo.

@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling f878442 on forward_fix_tests into bdfe27b on master.

cristianbote
cristianbote reviewed Mar 14, 2019
View reviewed changes
compat/src/index.js Outdated Show resolved Hide resolved
@cristianbote cristianbote self-requested a review March 14, 2019 17:11
cristianbote
cristianbote approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marvinhagemeister marvinhagemeister merged commit ddab478 into master Mar 14, 2019
@marvinhagemeister marvinhagemeister added this to Closed in Beta Issues via automation Mar 14, 2019
@marvinhagemeister marvinhagemeister deleted the forward_fix_tests branch March 14, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianbote cristianbote cristianbote approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Beta Issues
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @cristianbote