Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) - effect execution and cleanup order #1501

Merged
merged 7 commits into from
Apr 5, 2019

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 2, 2019

Fixes: #1500

Effects were being cleaned up and then invoked which is not the right order if we are conforming to react, where all effects first get cleaned up before new ones get invoked.

Edit:
+13B

@JoviDeCroock JoviDeCroock changed the title fix: effect execution order (fix) - effect execution and cleanup order Apr 2, 2019
@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling fe735c3 on fix/effect_execution_order into 149376d on master.

hooks/src/index.js Outdated Show resolved Hide resolved
hooks/src/index.js Show resolved Hide resolved
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍 💯

@marvinhagemeister marvinhagemeister merged commit 98f0d7e into master Apr 5, 2019
@marvinhagemeister marvinhagemeister deleted the fix/effect_execution_order branch April 5, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants