Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) - warn about deprecated properties #1511

Merged
merged 2 commits into from
Apr 5, 2019
Merged

(feat) - warn about deprecated properties #1511

merged 2 commits into from
Apr 5, 2019

Conversation

JoviDeCroock
Copy link
Member

Credits to @developit for the idea.

This warns about trying to access certain props and throws upon trying to set them.

@coveralls
Copy link

coveralls commented Apr 4, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling efc011a on feat/warnDeprecatedProps into 98f0d7e on master.

marvinhagemeister
marvinhagemeister approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marvinhagemeister marvinhagemeister merged commit b5968c6 into master Apr 5, 2019
@marvinhagemeister marvinhagemeister deleted the feat/warnDeprecatedProps branch April 5, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoviDeCroock @coveralls @developit @marvinhagemeister