Fix this inside event handlers
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @le0nik. I'll merge this shortly (I've been on vacation but I'm back tomorrow night) and do a round of testing on a bunch of codebase to ensure nothing breaks. |
|
Can confirm, your PR is what we should be doing: http://jsfiddle.net/developit/dorupezh/ |
|
@developit Thanks for checking it! Is there anything else I can do to get this merged? Right now I have to use |
|
I will get a beta out this morning. |
marvinhagemeister
pushed a commit
that referenced
this pull request
Mar 2, 2019
Fix hydration and Fragments
marvinhagemeister
pushed a commit
that referenced
this pull request
Mar 15, 2022
* Fix accidental camelCasing of CSS Variables * Add test * Re-add non-dimensional guard (whoops!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment for details.