(fix) - portals #1749
Merged
(fix) - portals #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
commented
Jul 2, 2019
| @@ -178,8 +178,145 @@ describe('Portal', () => { | |||
| } | |||
|
|
|||
| render(<App />, root); | |||
| expect(dialog.childNodes.length).to.equal(1); | |||
| expect(dialog.childNodes.length).to.equal(2); | |||
There was a problem hiding this comment.
This is because of the empty textNode, one would expect replaceNode to delete it but for some reason it isn't deleted.
developit
reviewed
Jul 3, 2019
8 tasks
marvinhagemeister
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Sweet 👍 💯 As said in Slack we can revisit the root handling after the X release. For now this is the best solution we could've wished for and compat doesn't have to be as strict about size. Users that won't use Portals won't be affected anyway, because of tree shaking 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
1018112311410388B to the compat package 👎This is a remake of: #1713
I needed to clear my head a bit and start over I felt like I was stuck in a rut.
I have almost gotten to the fix the only remaining issue is that when we insert another portal in the same container and unmount one of them we lose both. I don't know if this is an issue or not.... Let's assume it is, working on a fix for it but it can possibly get quite complicated.
One of the options would be to check the _children of the array for an existing portal and if there is one remove from the array.... I’m not sure about this