Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last element always losing focus #1831

Closed
wants to merge 1 commit into from
Closed

Conversation

marvinhagemeister
Copy link
Member

Fixes #1829 .
Adds +10 B.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.69% when pulling 4f77b04 on fix_focus_loss into e7c39e8 on master.

@alebastr
Copy link

alebastr commented Aug 3, 2019

This actually works only for the specific element order from my initial reproduction script.
The issue remains if there's more than one node after Wrapper component, i.e. https://codepen.io/alebastr/pen/OKxjgZ

src/diff/children.js Show resolved Hide resolved
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind my comment, that would result into the else branch and wouldn’t save bytes to add a clause for that.

Looks great 💯

@developit
Copy link
Member

@alebastr has a good point. I'm thinking about this one.

@marvinhagemeister
Copy link
Member Author

yeah this is probably not the right fix for that.

@cristianbote cristianbote deleted the fix_focus_loss branch August 13, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0.0-rc.1] Component with conditional render result forces remount of siblings
5 participants