Allow fallback of Suspense to be mounted multiple times #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2019
aduh95
added a commit
to aduh95/preact
that referenced
this pull request
Aug 13, 2019
It seems there is some kind of race condition here, because sometimes the loading elements disapear, sometimes they don't This also put in evidence a problem with nested Suspence components Refs: preactjs#1859 Refs: preactjs#1813
aduh95
added a commit
to aduh95/preact
that referenced
this pull request
Aug 13, 2019
It seems there is some kind of race condition here, because sometimes the loading elements disappear, sometimes they don't. This also puts in evidence a problem with nested Suspence components. Refs: preactjs#1859 Refs: preactjs#1813
aduh95
added a commit
to aduh95/preact
that referenced
this pull request
Aug 13, 2019
It seems there is some kind of race condition here, because sometimes the loading elements disappear, sometimes they don't. This also puts in evidence a problem with nested Suspence components. Refs: preactjs#1859 Refs: preactjs#1813
|
Just as a short update. I found that the duplicate dom of some components can be prevented by adding a guard to _childDidSuspend that prevents tracking promises multiple times. It does not solve the stale fallback dom to still be present. During these investigations I found further issues with dom nodes that are mounted as siblings to a suspending component. As a result of these issues I started investigating two-phase rendering. TL;DR I looked into the issue and think Suspense is not possible with the current implementation of preact. The two phase render will take a lot of time to be built and will land post 10.0.0 release |
|
Closing this one as we need a two-phase diff algo to properly solve these issues |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to reproduce #1813 in our demo app but with some debugging I came across the fact that the
_domproperty was missing on the fallback vnode. The reason for that seems to be thecoerceToVNodein render since it clones the vnode. What I do not get is why I can not reproduce this in the demo app.This PR adds 14B to preact and compat each.
Anybody has any ideas how to repro in demo?
TODO: