Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0 (aka X) #1960

Merged
merged 1 commit into from Oct 1, 2019
Merged

Release 10.0.0 (aka X) #1960

merged 1 commit into from Oct 1, 2019

Conversation

marvinhagemeister
Copy link
Member

馃帀

JoviDeCroock
JoviDeCroock approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEEEES!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.767% when pulling f27d3a4 on release-10.0.0 into 620df71 on master.

@marvinhagemeister marvinhagemeister merged commit 9ddc04e into master Oct 1, 2019
@marvinhagemeister marvinhagemeister deleted the release-10.0.0 branch October 1, 2019 18:21
@andrewiggins
Copy link
Member

:shipit: 馃巻 馃榿 馃殌 馃帀 wooooo!!!

@cristianbote
Copy link
Member

Let's get it going! 馃憤 馃帀馃挴馃挭鈿涳笍馃巶

kristoferbaxter
kristoferbaxter reviewed Oct 1, 2019
View reviewed changes
Copy link
Collaborator

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Well done all.

@developit
Copy link
Member

the coverage always goes up

@SolarLiner
Copy link
Contributor

rides that rocketship TO THE MOON!!! 馃殌馃殌馃殌

@maxmilton
Copy link

FYI, the links in the release note are broken:

@Kanaye
Copy link

Kanaye commented Oct 2, 2019

The links you just posted work fine for me 馃 Can you try them in an other browser ? While I've no idea why, but somtimes service workers can get "stuck".

@maxmilton
Copy link

maxmilton commented Oct 2, 2019 •
edited

Looks like they were broken before (404 pages) and at that point they must have been cached in my browser (service worker?). After force reloading the page the correct content was loaded 馃帀

I should have done a full reload earlier... sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter left review comments

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@cristianbote cristianbote Awaiting requested review from cristianbote

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet