(feat) - cleanup changing refs correctly #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins and
marvinhagemeister
JoviDeCroock
force-pushed
the
feat/cleanup-stale-refs
branch
from
b88260b
to
e94648f
Compare
JoviDeCroock
requested review from
andrewiggins,
ForsakenHarmony and
cristianbote
sventschui
reviewed
Nov 1, 2019
src/diff/index.js
Outdated
| @@ -381,9 +381,9 @@ function diffElementNodes( | |||
| * @param {any} value | |||
| * @param {import('../internal').VNode} vnode | |||
| */ | |||
| export function applyRef(ref, value, vnode) { | |||
| export function applyRef(ref, value, vnode, oldRef) { | |||
There was a problem hiding this comment.
On my phone so maybe I’m a bit lost here but what’s this argument for?
There was a problem hiding this comment.
oops, me being dumb good spot 👍
No no, Thank YOU for the idea on how to reduce size, hero! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2052
This differentiates in one aspect and that is that we do
instead of
nullcalls
valuecalls