Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits #2251

Merged
merged 9 commits into from Jan 27, 2020
Merged

extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits #2251

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73af8b2
extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits
Jan 15, 2020
9f3af05
remove unnecessary trailing pipe in CAMEL_PROPS regex
Jan 16, 2020
177c288
add test for svg attribute (clipPathUnits) manipulation
Jan 16, 2020
2cfd44f
adjust CAMEL_PROPS regex to passes tests
Jan 16, 2020
8fc49b6
Merge branch 'master' into bugfix/extend_normalization-regex
friebe Jan 17, 2020
809f38f
refactor svg.test to manipulation attributePathUnits
Jan 17, 2020
32f43a6
remove "clip" from CAMEL_PROPS regex
Jan 17, 2020
bbbc33c
Merge branch 'master' into bugfix/extend_normalization-regex
friebe Jan 24, 2020
b74938e
Merge branch 'master' into bugfix/extend_normalization-regex
developit Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion compat/src/render.js
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ import {
} from 'preact';
import { applyEventNormalization } from './events';

const CAMEL_PROPS = /^(?:accent|alignment|arabic|baseline|cap|clip|color|fill|flood|font|glyph|horiz|marker|overline|paint|stop|strikethrough|stroke|text|underline|unicode|units|v|vector|vert|word|writing|x)[A-Z]/;
const CAMEL_PROPS = /^(?:accent|alignment|arabic|baseline|cap|color|fill|flood|font|glyph|horiz|marker|overline|paint|stop|strikethrough|stroke|text|underline|unicode|units|v|vector|vert|word|writing|x)[A-Z]/;

// Some libraries like `react-virtualized` explicitly check for this.
Component.prototype.isReactComponent = {};
Expand Down
16 changes: 16 additions & 0 deletions compat/test/browser/svg.test.js
View file
Open in desktop
Expand Up @@ -66,4 +66,20 @@ describe('svg', () => {
)
);
});

it('should render SVG to DOM without name (clipPathUnits) attribute manipulation', () => {
React.render(
<svg>
<clipPath id="hexagon" clipPathUnits="objectBoundingBox">
<polygon points="0.5 0, 1 0.25, 1 0.75, 0.5 1, 0 0.75, 0 0.25" />
</clipPath>
</svg>,
scratch
);
expect(serializeHtml(scratch)).to.eql(
sortAttributes(
'<svg><clipPath id="hexagon" clipPathUnits="objectBoundingBox"><polygon points="0.5 0, 1 0.25, 1 0.75, 0.5 1, 0 0.75, 0 0.25" /></clipPath></svg>'
)
);
});
});