extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits

[friebe]

issue #2036

[coveralls]

Coverage remained the same at 99.807% when pulling b74938e on friebe:bugfix/extend_normalization-regex into a6cab5b on preactjs:master.

[JoviDeCroock]

Hey, thanks for the PR could you add a test?

[friebe]

@JoviDeCroock Shall i build a new test file for it or shall i extend the existing test/svg.test.js file ?

[friebe]

Oh man i need help. Why are now the checks and the Pica CI failed ?

[JoviDeCroock]

  svg
    ✖ should render SVG to DOM #2
      HeadlessChrome 73.0.3683 (Linux 0.0.0)
    AssertionError: expected '<svg viewBox="0 0 100 100"><text textAnchor="mid">foo</text><path d="M 0 0 L 100 100" vectorEffect="non-scaling-stroke"></path></svg>' to equal '<svg viewBox="0 0 100 100"><text text-anchor="mid">foo</text><path d="M 0 0 L 100 100" vector-effect="non-scaling-stroke"></path></svg>'
      + expected - actual
      -<svg viewBox="0 0 100 100"><text textAnchor="mid">foo</text><path d="M 0 0 L 100 100" vectorEffect="non-scaling-stroke"></path></svg>
      +<svg viewBox="0 0 100 100"><text text-anchor="mid">foo</text><path d="M 0 0 L 100 100" vector-effect="non-scaling-stroke"></path></svg>

Failing test and failing coverage

[friebe]

@JoviDeCroock mistake. i revert it to color.

[JoviDeCroock]

Looks good to me, thanks for contributing this!

[friebe]

That sounds good to me @JoviDeCroock. What are my next steps to close this PR ?

[JoviDeCroock]

@friebe I'll wait for @marvinhagemeister or @developit to also give it an approval.

I see you have disabled the edit from maintainers this allows us to ensure your branch is up to date with master. That means that if we get it approved we'll probably ask you to set your branch up to date with master by rebasing or merging master into this branch.

[marvinhagemeister]

Sweet 👍 Looks good to me 💯

[JoviDeCroock]

Hey @friebe

When you get time could you update your branch or give us the right to do so by ticking "allow edit from maintainers"

[friebe]

What does it mean check "compressed Size / build" fail.
Even the details of the error do not give me any information to understand the situation.

[JoviDeCroock]

It can't access your branch, pinging @developit (you have a blocker with requested changes and the compressed-size plugin can't access forked repo's)

[developit]

Looks good! sorry for the slow response.

(aside: the size bot no longer fails PRs when it can't comment, it'll be a while before Github has a fix for the fork permissions thing)

[pika-ci]

🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN:

npm install https://cdn.pika.dev/preact/master