Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assigning to readonly style #2723

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

JoviDeCroock
Copy link
Member

Fixes: #2722

@charlier if you get the chance you can use our pika-distribution (one of the PR-checks) to see if it works locally for you.

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.8%) to 99.022% when pulling 9899efa on avoid-assigning-to-readonly-style into a574a9e on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I recall us having assigned to cssText earlier in our code base 👍

@marvinhagemeister marvinhagemeister merged commit 952a7e2 into master Aug 28, 2020
@marvinhagemeister marvinhagemeister deleted the avoid-assigning-to-readonly-style branch August 28, 2020 11:24
@github-actions
Copy link

Size Change: +22 B (0%)

Total Size: 40.4 kB

Filename Size Change
dist/preact.js 3.91 kB +6 B (0%)
dist/preact.min.js 3.93 kB +5 B (0%)
dist/preact.module.js 3.93 kB +6 B (0%)
dist/preact.umd.js 3.97 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.26 kB 0 B
compat/dist/compat.module.js 3.29 kB 0 B
compat/dist/compat.umd.js 3.33 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
hooks/dist/hooks.js 1.09 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.17 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@klh
Copy link

klh commented Sep 3, 2020

this causes IE11 to fail making preact 10.4.7 and 10.4.8 incompatible with IE11.

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Sep 3, 2020

@klh no this fixes that, this PR is aimed at fixing the linked issue which is what you're describing. This is currently unpublished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 throws errors when using the style attribute
3 participants