set null for custom elements #3280

JoviDeCroock · 2021-10-10T12:48:28Z

Fixes #3276

github-actions · 2021-10-10T12:48:42Z

📊 Tachometer Benchmark Results

Summary

duration

02_replace1k: unsure 🔍 -3% - +2% (-4.28ms - +3.25ms)
^{preact-local vs preact-master}
02_replace1k: 148.82ms - 159.09ms
03_update10th1k_x16: unsure 🔍 -5% - +5% (-1.98ms - +1.96ms)
^{preact-local vs preact-master}
03_update10th1k_x16: 53.54ms - 56.56ms
07_create10k: unsure 🔍 -3% - +1% (-51.24ms - +10.22ms)
^{preact-local vs preact-master}
07_create10k: 1398.91ms - 1407.07ms
filter_list: unsure 🔍 -10% - +12% (-7.09ms - +8.71ms)
^{preact-local vs preact-master}
filter_list: 35.62ms - 40.39ms
hydrate1k: unsure 🔍 -1% - +2% (-1.88ms - +2.72ms)
^{preact-local vs preact-master}
hydrate1k: 173.45ms - 181.47ms
many_updates: unsure 🔍 -11% - +3% (-10.04ms - +2.60ms)
^{preact-local vs preact-master}
many_updates: 83.60ms - 98.87ms
text_update: slower ❌ 1% - 6% (0.04ms - 0.17ms)
^{preact-local vs preact-master}
text_update: 2.68ms - 2.75ms

usedJSHeapSize

02_replace1k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
^{preact-local vs preact-master}
02_replace1k: 3.76ms - 3.78ms
03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
03_update10th1k_x16: 3.65ms - 3.65ms
07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
07_create10k: 25.59ms - 25.59ms
filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
filter_list: 1.81ms - 1.81ms
hydrate1k: unsure 🔍 -0% - +0% (-0.03ms - +0.02ms)
^{preact-local vs preact-master}
hydrate1k: 6.41ms - 6.43ms
many_updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
many_updates: 4.87ms - 4.87ms
text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
text_update: 1.05ms - 1.05ms

Results

02_replace1k

Browser: chrome-headless 102.0.5005.115
Sample size: 80
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	137.39ms - 143.24ms	-	unsure 🔍 -2% - +3% -3.25ms - +4.28ms
preact-local	137.42ms - 142.18ms	unsure 🔍 -3% - +2% -4.28ms - +3.25ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.76ms - 3.78ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.02ms
preact-local	3.76ms - 3.77ms	unsure 🔍 -0% - +0% -0.02ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	46.85ms - 47.79ms	-	faster ✔ 0% - 3% 0.19ms - 1.60ms
preact-local	47.69ms - 48.74ms	slower ❌ 0% - 3% 0.19ms - 1.60ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	65.94ms - 68.87ms	-	faster ✔ 0% - 7% 0.23ms - 4.94ms
preact-local	68.15ms - 71.83ms	slower ❌ 0% - 7% 0.23ms - 4.94ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	53.40ms - 57.98ms	-	unsure 🔍 -4% - +7% -2.42ms - +3.81ms
preact-local	52.88ms - 57.11ms	unsure 🔍 -7% - +4% -3.81ms - +2.42ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	55.04ms - 60.26ms	-	unsure 🔍 -9% - +3% -5.58ms - +1.98ms
preact-local	56.72ms - 62.18ms	unsure 🔍 -4% - +10% -1.98ms - +5.58ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	102.06ms - 112.21ms	-	unsure 🔍 -7% - +6% -7.80ms - +6.92ms
preact-local	102.24ms - 112.90ms	unsure 🔍 -6% - +7% -6.92ms - +7.80ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	39.71ms - 42.45ms	-	unsure 🔍 -6% - +4% -2.40ms - +1.52ms
preact-local	40.11ms - 42.92ms	unsure 🔍 -4% - +6% -1.52ms - +2.40ms	-

02_replace1k

Browser: chrome-headless 102.0.5005.115
Sample size: 100
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	148.82ms - 159.09ms	-

usedJSHeapSize

Version	Avg time	vs
	3.76ms - 3.78ms	-

run-warmup-0

Version	Avg time	vs
	47.02ms - 48.50ms	-

run-warmup-1

Version	Avg time	vs
	73.90ms - 78.33ms	-

run-warmup-2

Version	Avg time	vs
	56.17ms - 60.91ms	-

run-warmup-3

Version	Avg time	vs
	61.67ms - 65.69ms	-

run-warmup-4

Version	Avg time	vs
	114.92ms - 124.84ms	-

run-final

Version	Avg time	vs
	44.14ms - 47.60ms	-

03_update10th1k_x16

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	38.98ms - 41.44ms	-	unsure 🔍 -5% - +5% -1.96ms - +1.98ms
preact-local	38.66ms - 41.74ms	unsure 🔍 -5% - +5% -1.98ms - +1.96ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.65ms - 3.65ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	3.65ms - 3.65ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

03_update10th1k_x16

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	53.54ms - 56.56ms	-

usedJSHeapSize

Version	Avg time	vs
	3.65ms - 3.65ms	-

07_create10k

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1603.43ms - 1661.78ms	-	unsure 🔍 -1% - +3% -10.22ms - +51.24ms
preact-local	1602.43ms - 1621.74ms	unsure 🔍 -3% - +1% -51.24ms - +10.22ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.59ms - 25.59ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	25.59ms - 25.59ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

07_create10k

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	1398.91ms - 1407.07ms	-

usedJSHeapSize

Version	Avg time	vs
	25.59ms - 25.59ms	-

filter_list

Browser: chrome-headless 102.0.5005.115
Sample size: 70
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	67.17ms - 78.72ms	-	unsure 🔍 -12% - +10% -8.71ms - +7.09ms
preact-local	68.37ms - 79.15ms	unsure 🔍 -10% - +12% -7.09ms - +8.71ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.81ms - 1.81ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	1.81ms - 1.81ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

filter_list

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	35.62ms - 40.39ms	-

usedJSHeapSize

Version	Avg time	vs
	1.81ms - 1.81ms	-

hydrate1k

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	125.52ms - 128.77ms	-	unsure 🔍 -2% - +1% -2.72ms - +1.88ms
preact-local	125.94ms - 129.20ms	unsure 🔍 -1% - +2% -1.88ms - +2.72ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	6.43ms - 6.46ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.03ms
preact-local	6.42ms - 6.45ms	unsure 🔍 -0% - +0% -0.03ms - +0.02ms	-

hydrate1k

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	173.45ms - 181.47ms	-

usedJSHeapSize

Version	Avg time	vs
	6.41ms - 6.43ms	-

many_updates

Browser: chrome-headless 102.0.5005.115
Sample size: 70
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	81.64ms - 91.61ms	-	unsure 🔍 -3% - +12% -2.60ms - +10.04ms
preact-local	79.02ms - 86.79ms	unsure 🔍 -11% - +3% -10.04ms - +2.60ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.87ms - 4.87ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	4.87ms - 4.87ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

many_updates

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	83.60ms - 98.87ms	-

usedJSHeapSize

Version	Avg time	vs
	4.87ms - 4.87ms	-

text_update

Browser: chrome-headless 102.0.5005.115
Sample size: 260
Built by: Benchmarks #801
Commit: 8fc6dc6

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.00ms - 3.07ms	-	faster ✔ 1% - 5% 0.04ms - 0.17ms
preact-local	3.08ms - 3.20ms	slower ❌ 1% - 6% 0.04ms - 0.17ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.04ms - 1.04ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	1.05ms - 1.05ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

text_update

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #800
Commit: 8fc6dc6

duration

Version	Avg time	vs
	2.68ms - 2.75ms	-

usedJSHeapSize

Version	Avg time	vs
	1.05ms - 1.05ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2021-10-10T12:50:54Z

Size Change: +62 B (0%)

Total Size: 42.9 kB

Filename	Size	Change
`dist/preact.js`	4.05 kB	+19 B (0%)
`dist/preact.min.js`	4.08 kB	+14 B (0%)
`dist/preact.module.js`	4.07 kB	+16 B (0%)
`dist/preact.umd.js`	4.11 kB	+13 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`compat/dist/compat.js`	3.48 kB	0 B
`compat/dist/compat.module.js`	3.46 kB	0 B
`compat/dist/compat.umd.js`	3.54 kB	0 B
`debug/dist/debug.js`	3.01 kB	0 B
`debug/dist/debug.module.js`	3 kB	0 B
`debug/dist/debug.umd.js`	3.09 kB	0 B
`devtools/dist/devtools.js`	231 B	0 B
`devtools/dist/devtools.module.js`	239 B	0 B
`devtools/dist/devtools.umd.js`	307 B	0 B
`hooks/dist/hooks.js`	1.23 kB	0 B
`hooks/dist/hooks.module.js`	1.25 kB	0 B
`hooks/dist/hooks.umd.js`	1.32 kB	0 B
`jsx-runtime/dist/jsxRuntime.js`	317 B	0 B
`jsx-runtime/dist/jsxRuntime.module.js`	327 B	0 B
`jsx-runtime/dist/jsxRuntime.umd.js`	395 B	0 B
`test-utils/dist/testUtils.js`	444 B	0 B
`test-utils/dist/testUtils.module.js`	444 B	0 B
`test-utils/dist/testUtils.umd.js`	521 B	0 B

_{compressed-size-action}

coveralls · 2021-10-10T13:05:45Z

Coverage remained the same at 99.446% when pulling 8fc6dc6 on set-null-custom-el into bc02039 on master.

src/diff/props.js

test/browser/render.test.js

JoviDeCroock · 2023-04-24T10:43:38Z

Closing due to inactivity

set null for custom elements

99d1a63

correct

add858a

jramanat-oracle reviewed Oct 11, 2021

View reviewed changes

src/diff/props.js Outdated Show resolved Hide resolved

JoviDeCroock added 4 commits October 11, 2021 17:25

Update props.js

5950e97

Update index.js

6634403

Update props.js

1c01c39

undo lockfile changes

e812a81

jramanat-oracle reviewed Oct 13, 2021

View reviewed changes

test/browser/render.test.js Outdated Show resolved Hide resolved

jramanat-oracle approved these changes Oct 13, 2021

View reviewed changes

Update render.test.js

3411689

JoviDeCroock requested review from developit, andrewiggins and marvinhagemeister October 13, 2021 22:53

JoviDeCroock added 2 commits November 3, 2021 00:23

Merge branch 'master' into set-null-custom-el

11f1ee0

Merge branch 'master' into set-null-custom-el

e00af2a

JoviDeCroock closed this May 17, 2022

JoviDeCroock deleted the set-null-custom-el branch May 17, 2022 15:32

JoviDeCroock restored the set-null-custom-el branch June 17, 2022 22:43

JoviDeCroock reopened this Jun 17, 2022

Merge branch 'master' into set-null-custom-el

8fc6dc6

JoviDeCroock closed this Apr 24, 2023

JoviDeCroock deleted the set-null-custom-el branch April 24, 2023 10:43

set null for custom elements #3280

set null for custom elements #3280

Conversation

JoviDeCroock commented Oct 10, 2021

github-actions bot commented Oct 10, 2021 • edited

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

github-actions bot commented Oct 10, 2021 • edited

coveralls commented Oct 10, 2021 • edited

JoviDeCroock commented Apr 24, 2023

github-actions bot commented Oct 10, 2021 •

edited

github-actions bot commented Oct 10, 2021 •

edited

coveralls commented Oct 10, 2021 •

edited