regression: serializing class={{ }} objects for SVG tags #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7c6ab6 broke serializing `class={{}}` for SVG elements. This fixes that regression and does a little cleans up the logic a little bit. I've also added a test verifying the proper behavior for SVG.
|
I believe there is already a commit on master for this: 2de530b |
|
The test currently fails on master because So |
|
oooh dang, good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e7c6ab6 broke serializing
class={{ }}for SVG elements. This fixesthat regression and does a little cleans up the logic a little bit.
I've also added a test verifying the proper behavior for SVG.