Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of <Fragment /> for better TypeScript compatibility with @emotion/react and @types/react. #3431

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Change type of <Fragment /> for better TypeScript compatibility with @emotion/react and @types/react. #3431

merged 1 commit into from
Jan 26, 2022

Conversation

rolftimmermans
Copy link
Contributor

This addresses #3423.

@rschristian rschristian linked an issue Jan 23, 2022 that may be closed by this pull request
Fragment TypeScript type is unnecessarily complicated and causes type checking error when used with @emotion/react #3423
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.627% when pulling 38ba5fc on rolftimmermans:master into 2af05f5 on preactjs:master.

@JoviDeCroock JoviDeCroock merged commit 41f9b4b into preactjs:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rolftimmermans @coveralls @JoviDeCroock