Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup of debounceRendering hook after exceptions #3530

Merged
merged 3 commits into from Apr 28, 2022

Conversation

robertknight
Copy link
Member

@robertknight robertknight commented Apr 28, 2022

Fix cleanup of the options.debounceRendering hook when an effect run
during an act callback throws. Failing to reset this hook could cause
subsequent state updates that happen outside of act not to be applied.

Fix cleanup of the `options.debounceRendering` hook when an effect run
during an `act` callback throws. Failing to reset this hook could cause
subsequent state updates happening outside of `act` for not to be applied.
@coveralls
Copy link

coveralls commented Apr 28, 2022

Coverage Status

Coverage remained the same at 99.44% when pulling e8a0fed on fix-act-teardown-after-effect-exception into 5bb58e2 on master.

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Size Change: +18 B (0%)

Total Size: 42.4 kB

Filename Size Change
test-utils/dist/testUtils.js 444 B +7 B (1%)
test-utils/dist/testUtils.module.js 444 B +5 B (1%)
test-utils/dist/testUtils.umd.js 521 B +6 B (1%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.46 kB 0 B
compat/dist/compat.module.js 3.44 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 3.98 kB 0 B
dist/preact.min.js 4.01 kB 0 B
dist/preact.module.js 4 kB 0 B
dist/preact.umd.js 4.04 kB 0 B
hooks/dist/hooks.js 1.17 kB 0 B
hooks/dist/hooks.module.js 1.19 kB 0 B
hooks/dist/hooks.umd.js 1.25 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B

compressed-size-action

@robertknight robertknight merged commit c7b14ef into master Apr 28, 2022
@robertknight robertknight deleted the fix-act-teardown-after-effect-exception branch April 28, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants