Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indeterminate's SignalLike type #3971

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: indeterminate's SignalLike type #3971

merged 1 commit into from
Apr 17, 2023

Conversation

rschristian
Copy link
Member

I think we merged in the addition of indeterminate here only after adding | undefined to all the SignalLikes, but I didn't catch that it needed a touch-up.

@github-actions
Copy link

Coverage Status

Coverage: 99.706%. Remained the same when pulling 65a5462 on types/indeterminate into 362bcd8 on master.

@marvinhagemeister marvinhagemeister merged commit d8e9ba2 into master Apr 17, 2023
@marvinhagemeister marvinhagemeister deleted the types/indeterminate branch April 17, 2023 14:19
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
Merged
JoviDeCroock added a commit that referenced this pull request Jan 22, 2024
@JoviDeCroock
backport #3971
740bb7b
JoviDeCroock added a commit that referenced this pull request Jan 23, 2024
@JoviDeCroock
Backport 10.14 release line (#4263)
f0144e6 
* backport #3968

* backport #3964

* backport #3997

* backport #3995

* backport #3970

* backport #3971

* backport #3990

* backport #3963

* backport #3962

* backport #3960

* backport #3956

* Revert "backport #3963"

This reverts commit 86a372a.

* define public type

* fix newline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rschristian @marvinhagemeister