chore(workspace): firefox saucelabs not running #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins and
marvinhagemeister
JoviDeCroock
force-pushed
the
fix-sauce-labs-firefox
branch
from
fed508a
to
bee8988
Compare
JoviDeCroock
commented
Apr 7, 2023
| @@ -22302,7 +23146,7 @@ | |||
| "requires": { | |||
| "global-agent": "^2.1.12", | |||
| "saucelabs": "^4.6.3", | |||
| "webdriverio": "^6.7.0" | |||
| "webdriverio": "7.30.2" | |||
There was a problem hiding this comment.
this is the important place where it's bumped, sauce-launcher will leverage the new 7.30.2
andrewiggins
approved these changes
Apr 7, 2023
Merged
JoviDeCroock
added a commit
that referenced
this pull request
Jan 22, 2024
This reverts commit 86a372a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FireFox made a change with regards to their debug port, this was updated in webdriver 7.27, however the
karma-sauce-launcherseems to not have bumped the dep yet so in this PR we force it so we can make the tests pass againhttps://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022